You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I am not seeing any issues at the moment, but from a design perspective, will there be any benefit in strictly defining what header timestamp refers to and fixing any inconsistencies that are currently implemented?
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
Given a module starts execution at
t0
, finishes execution att1
, and produces an output with header timestampx
, what is the value ofx
?If the definition of header timestamp indicates when the output is being produced, then
x == t1
should always be true. For example, in the following code snippethttps://github.com/autowarefoundation/autoware.universe/blob/edd5824b01fbc3e6d5eebfb15f50da9af95f1cba/planning/behavior_path_planner/src/behavior_path_planner_node.cpp#L692-L717
output.header.stamp
seems to consider the processing time ofmotion_utils::convertToPath
.In a different function https://github.com/autowarefoundation/autoware.universe/blob/edd5824b01fbc3e6d5eebfb15f50da9af95f1cba/planning/behavior_path_planner/src/behavior_path_planner_node.cpp#L719, header timestamp is assigned once, and seems like the same value may be used again at https://github.com/autowarefoundation/autoware.universe/blob/edd5824b01fbc3e6d5eebfb15f50da9af95f1cba/planning/behavior_path_planner/src/behavior_path_planner_node.cpp#L438C34-L438C38. Assigning header timestamp only once at an early stage ignores the processing needed, therefore
x
may be some value betweent0
andt1
(actually closer tot0
since it is assigned at an early stage).I am not seeing any issues at the moment, but from a design perspective, will there be any benefit in strictly defining what header timestamp refers to and fixing any inconsistencies that are currently implemented?
Beta Was this translation helpful? Give feedback.
All reactions