-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ansible/artifacts): add rtmdet onnx model #5605
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Barış Zeren <[email protected]>
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
@xmfcx Can you review this PR? |
Could you pass pre-commit-ci checks? |
Signed-off-by: Barış Zeren <[email protected]>
@xmfcx All checks are OK now. |
- name: Move extracted files to the final destination | ||
ansible.builtin.copy: | ||
src: "{{ data_dir }}/tensorrt_rtmdet/tensorrt_rtmdet_onnx_models/" | ||
dest: "{{ data_dir }}/tensorrt_rtmdet/" | ||
mode: "0644" | ||
remote_src: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- name: Move extracted files to the final destination | |
ansible.builtin.copy: | |
src: "{{ data_dir }}/tensorrt_rtmdet/tensorrt_rtmdet_onnx_models/" | |
dest: "{{ data_dir }}/tensorrt_rtmdet/" | |
mode: "0644" | |
remote_src: true | |
- name: Move extracted files to the final destination | |
ansible.builtin.command: > | |
mv {{ data_dir }}/tensorrt_rtmdet/tensorrt_rtmdet_onnx_models/* {{ data_dir }}/tensorrt_rtmdet/ | |
args: | |
removes: "{{ data_dir }}/tensorrt_rtmdet/tensorrt_rtmdet_onnx_models/" |
This way, we won't need the next step since it will be moved.
Also, removes
argument tells Ansible to only execute the command if the specified path (in this case, {{ data_dir }}/tensorrt_rtmdet/tensorrt_rtmdet_onnx_models/
) exists.
If the path does not exist, the task will be skipped, ensuring idempotency (i.e., running the playbook multiple times will not re-run this command unnecessarily).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The * wildcard doesn’t work with ansible.builtin.command, so I use ansible.builtin.shell. Is it okay for you?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added some small suggestions, thanks for the PR🐝!
Signed-off-by: Barış Zeren <[email protected]>
Description
This PR adds some Ansible tasks to download tensorrt rtmdet model.
Related Links
How was this PR tested?
Notes for reviewers
None.
Effects on system behavior
None.