feat: add the empty route test and empty map test #38
+22
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zhe Shen <[email protected]>
Signed-off-by: Zhe Shen <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #38 +/- ##
==========================================
+ Coverage 16.08% 16.24% +0.15%
==========================================
Files 42 42
Lines 3083 3090 +7
Branches 1395 1397 +2
==========================================
+ Hits 496 502 +6
+ Misses 2494 2493 -1
- Partials 93 95 +2
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
HansOersted
requested review from
kosuke55,
soblin,
Motsu-san,
mitsudome-r,
takayuki5168 and
youtalk
as code owners
youtalk
reviewed
Dec 12, 2024
Comment on lines
+29
to
+32
| if (route_msg.segments.empty()) { | ||
| std::cerr << "Route is empty, returning false." << std::endl; | ||
| return false; | ||
| } |
There was a problem hiding this comment.
Whether an empty route segment is considered invalid is a matter of interpretation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add the empty route test and empty map test.
Related links
Tests performed
Notes for reviewers
Interface changes
Effects on system behavior
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.