Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yarn version upgrade #112

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

csabbee
Copy link
Contributor

@csabbee csabbee commented Dec 13, 2024

Description

The aim of this PR is to update the version of the yarn package manager to the latest stable version: 4.5.3

Changes

  • setting packageManager property in the package.json file
  • modifying entries under resolutions (This was required because the previous setup got removed when running yarn install after the yarn version upgrade)
    • minimatch
    • nth-check
    • glob-parent
  • entries added under allowScripts which was visible in the console after running the postinstall script

Testing

I run all the scripts in package.json, apart from the sentry (which I assume needs some additional setup) run without any problem.

Obviously some additional testing is required, to really make sure nothing is broken

Screenshots:

Checklist for the author

Tick each of them when done or if not applicable.

  • I've covered new/modified business logic with Jest test cases. N/A
  • I've tested the changes myself before sending it to code review and QA.

@csabbee csabbee changed the title Yarn version update Yarn version upgrade Dec 13, 2024
Copy link
Contributor

@gergelylovas gergelylovas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the updates!
Seems like some changes are needed to the .github/workflow files to pass CI checks. Error: Cannot find module '/home/runner/work/core-extension/core-extension/.yarn/releases/yarn-4.5.3.cjs'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants