Rename l1ID -> subnetID #695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cam-schultz
requested review from
iansuvak,
richardpringle,
geoff-vball,
bernard-avalabs and
michaelkaplan13
bernard-avalabs
approved these changes
Jan 6, 2025
geoff-vball
approved these changes
Jan 6, 2025
iansuvak
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Partially reverts the recent nomenclature changes to continue to use
subnetIDinstead ofl1ID.subnetIDshould be used to refer to both Subnets that have not been converted, and L1s that have. It's not as explicit as it could be, but note that the ACP-77 message specifications usesubnetIDto identify the converted L1. Also note that thesubnetIDis the tx hash of theCreateSubnetTx, and therefore does not change when the Subnet is converted to an L1. As such, changing the name of the identifier of a static value depending on the Subnet/L1 status would be confusing in its own right. Eventually, once Subnets are fully deprecated in favor of L1s, it will make more sense to revisit this terminology.How this works
Renames all instances of
l1IDtosubnetIDHow this was tested
CI
How is this documented
Adds a note describing this nomenclature, as it jmay be confusing why validator manager contracts that by definition only apply to L1s would use the Subnet terminology.