Add timeout to remote ops #613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cam-schultz
requested review from
iansuvak,
richardpringle,
geoff-vball,
bernard-avalabs and
michaelkaplan13
geoff-vball
approved these changes
Jan 2, 2025
bernard-avalabs
approved these changes
Jan 6, 2025
iansuvak
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
#593 added an exponential backoff utility, useful for spacing out RPC requests and signature aggregation attempts. The exponential backoff utility as well as the backoff library require that the supplied operation will terminate. Some operations that use the utility consumed
context.Background()and so would not do so.How this works
Adds a timeout context to eth_subscribe and Warp API calls.
How this was tested
CI
How is this documented
Improves backoff utility documentation
cc @najeal