Allow passing tracked L1s config #616
Open
+33
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iansuvak
requested review from
richardpringle,
geoff-vball,
bernard-avalabs,
michaelkaplan13 and
cam-schultz
geoff-vball
approved these changes
Jan 3, 2025
bernard-avalabs
approved these changes
Jan 6, 2025
cam-schultz
reviewed
Jan 6, 2025
| TrackedL1s []string `mapstructure:"tracked-l1s" json:"tracked-l1s"` | ||
|
|
||
| // convenience fields | ||
| trackedL1s set.Set[ids.ID] |
There was a problem hiding this comment.
Let's initialize this with set.NewSet() in Validate. It should be safe as is, but I prefer explicit constructor calls over implicit zero value initialization whenever possible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Enables optional passing in of tracked L1s to signature-aggregator which allows for earlier connections and speeds up the tests in #694
How this works
How this was tested
Tested via E2E in #694 on the
How is this documented
TODO