Avail:0:1st Proposal:Integration of Avail DA layer with Arbitrum nitro #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
RISHABHAGRAWALZRA
commented
Apr 10, 2024
RISHABHAGRAWALZRA
commented
- Addition of Avail package with having store and retrieve logic in das
- Updation of nitro-contracts for support of avail header
- Addition of Avail in replay binary for fraud proving in the Arbitrator
feat: enable fraud proof, resolved validation error
nitro v2.1.3 -> nitro v2.2.5 + avail integration
…rification-v2.2.5
Arbitrum Nitro v2.3.1
rac-sri
requested changes
Apr 10, 2024
| LeafIndex uint64 `json:"leafIndex"` | ||
| LeafProof []gsrpc_types.Hash `json:"leafProof"` | ||
| RangeHash gsrpc_types.Hash `json:"rangeHash"` | ||
| } |
There was a problem hiding this comment.
i have written a much cleaner version for this code in OP. Can you refer that and clean this file up a bit please.
There was a problem hiding this comment.
Will cover this in my next pr
| if err != nil { | ||
| t.Fatalf("unable to unmarshal bridge api response, err=%v", err) | ||
| } | ||
| t.Logf("%+v", bridgdeApiResponse) |
There was a problem hiding this comment.
can we do some abstraction here, barely understandable in its current state
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.