Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add entities list to lookup.py #88

Closed
wants to merge 1 commit into from

Conversation

Niels-NTG
Copy link
Contributor

Add list of entities present in Minecraft 1.19.2, sourced from https://github.com/PrismarineJS/minecraft-data/blob/master/data/pc/1.19.2/entities.json

@avdstaaij
Copy link
Owner

This does seem useful, but I'm not sure if we should include it in GDPC for the same reason as in #83 (comment) (I'm careful about all additions that require permanent maintenance). Python-minecraft-data (https://github.com/SpockBotMC/python-minecraft-data) already provides to all PrismarineJS data, and seems maintained well enough. Is there any particular advantage to including this in GDPC directly?

@Niels-NTG
Copy link
Contributor Author

To be honest I forgot this existed as a Python package.

Having re-learned this now I admit there isn't really an advantage to including this data here directly. I do think that instead it could be beneficial to create a wrapper and/or util functions in gdpc that make use of this package such that lookup.py in its current form can be replaced.

@Niels-NTG Niels-NTG closed this Jun 7, 2023
@avdstaaij
Copy link
Owner

Adding wrappers for some common lists does indeed sound like a good idea! I've opened #89 for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants