avniproject/avni-webapp#1288 | avoid using ChecklistItemDetailBuilder…

… to set Lead ChecklistItemDetail
avniproject · Jul 24, 2024 · 0ecc274 · 0ecc274
1 parent fde707d
commit 0ecc274
Showing 1 changed file with 1 addition and 3 deletions.
diff --git a/avni-server-api/src/main/java/org/avni/server/builder/ChecklistDetailBuilder.java b/avni-server-api/src/main/java/org/avni/server/builder/ChecklistDetailBuilder.java
@@ -57,9 +57,7 @@ public ChecklistDetailBuilder withItems(List<ChecklistItemDetailRequest> items)
             builtItems.put(builtItemDetail.getUuid(), builtItemDetail);
         });
         //set dependentOn after all items in request have been processed so order of items in request does not matter for dependents
-        items.forEach(item -> new ChecklistItemDetailBuilder(this.get(), getExistingChecklistItemDetail(this.get(), item))
-                .withLeadItem(builtItems.get(item.getDependentOn()))
-                .build());
+        items.forEach(item -> getExistingChecklistItemDetail(this.get(), item).setLeadChecklistItemDetail(builtItems.get(item.getDependentOn())));
         return this;
     }