-
Notifications
You must be signed in to change notification settings - Fork 599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Imagebox resize svg fix #3881
base: master
Are you sure you want to change the base?
Imagebox resize svg fix #3881
Conversation
45fb76b
to
a44bd32
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3881 +/- ##
=======================================
Coverage 91.01% 91.01%
=======================================
Files 901 901
Lines 57566 57574 +8
=======================================
+ Hits 52392 52400 +8
Misses 5174 5174
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
You could have just asked them to uncheck the box, or tell them about the changes you'd like to see. Until merged, it's still their code, and the default for that setting is to allow for maintainers to push, so they consciously unchecked it. And you wouldn't have to wait long for at least a comment. Crylia is still active in the Discord. |
the idea of hunting down someone on other platform in order to force them to finish their PR on github - is a bit on the edge of stalking 🤗 |
What I meant to say with that is: If Elv had commented on the PR on GitHub, chances would have been very high that he would have gotten response. |
I didn't realize that button existed, and I checked it now. As for which one gets merged, I don't care too much, as the ultimate goal was to help fix some stuff (regardless of how much time I have to work on anything currently). So just pick the path of least resistance. |
Fork of #3802 because I can't push to that branch.
Changes: