Fix notification image reloading #3883
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This *should* allow to reload images when the path has not changed. I only did limited testing (aka, it doesn't crash and detect changes). See awesomeWM#2851
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #3883 +/- ##
==========================================
- Coverage 91.01% 90.99% -0.02%
==========================================
Files 901 902 +1
Lines 57566 57744 +178
==========================================
+ Hits 52392 52545 +153
- Misses 5174 5199 +25
Flags with carried forward coverage won't be shown. Click here to find out more.
|
sclu1034
suggested changes
Jan 2, 2024
Comment on lines
+345
to
+346
| -- @tparam[opt=false] boolean args.force Reload the image even if the path has | ||
| -- not changed. |
There was a problem hiding this comment.
I don't think it makes sense to implement this force parameter for all values of image. For anything but a path, there will be no change, and the resulting signals would be misleading ("emitted when the image changes").
Given that this is about being able to load from a path uncached, just make it explicit:
Suggested change
| -- @tparam[opt=false] boolean args.force Reload the image even if the path has | |
| -- not changed. | |
| -- @tparam[opt=false] boolean args.uncached Bypass the cache when loading the image. |
Either way, you're currently still not bypassing rsvg_handle_cache.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It might work. I ran the code, but I don't have "real" tests for this right now.