Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default to only use ARGB visual for ARGB client windows #3910

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yshui
Copy link

@yshui yshui commented Apr 13, 2024

Don't use the same visual for all windows.

And add a --full-argb option to force ARGB visual for all windows, which is the current default behavior.

Fixes #2408

Don't use the same visual for all windows.

And add a --full-argb option to force ARGB visual for all windows, which
is the current default behavior.

Fixes awesomeWM#2408
@yshui
Copy link
Author

yshui commented Apr 13, 2024

Maybe it's better to instead keep the current default, and enable the new behavior with an option, like --smart-argb or something 🤔

@Elv13
Copy link
Member

Elv13 commented Aug 18, 2024

Sorry for the delay, I don't have a lot of time for Awesome right now. Won't think break people who add transparent titlebars or use anti-aliased round corners?

@yshui
Copy link
Author

yshui commented Aug 18, 2024

@Elv13 yes, this will. alternatively we can also keep the default and add an option to enable this behavior, maybe --argb-if-needed.

@actionless
Copy link
Member

actionless commented Aug 18, 2024

yup, i also think it's better to preserve the current behavior (forced argb) as a default, at least til next major release

@Elv13
Copy link
Member

Elv13 commented Aug 20, 2024

@yshui Maybe deprecate --no-argb and add a --argb-mode=<on|off|ondemand> where on remains the default?

* ondemand and not auto because auto would imply it detects when it really needs it, which we cannot really do sanely because the users are free to render whatever they want in the titlebars.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use ARGB parents only for windows with ARGB
3 participants