-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Add flake8 and vim configs #466
base: master
Are you sure you want to change the base?
Conversation
rfleschenberg
commented
Nov 21, 2016
•
edited
Loading
edited
- Add flake8 config file
- Test it
- Add a flake8 check to travis
- Fix all current flake8 errors
If we add a .flake8 file, shouldn't we also add |
That would be a possibility. I usually have a flake8 check as a separate step in CI, so that CI can fail early if there are flake8 problems. But I never used py.test with |
After a quick look at https://pypi.python.org/pypi/pytest-flake8, I wonder what the benefit of this plugin over just running flake8 directly is. |
@rfleschenberg can we close this? |
It's ok if you close it, but I'd prefer to keep it open, but as a low-priority, "maybe if I have time" kind of thing :) |
About |
I'd prefer to read these from |
@@ -0,0 +1,4 @@ | |||
" Ideally, we would read these from .editorconfig, but Pymode doesn't seem to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you decide to remove the vim config, then you need to remove it