New error code for Secret not found (#33)

Updated from `ackerr.NotFound` to `SecretNotFound`
aws-controllers-k8s · Jul 21, 2021 · cdc2824 · cdc2824
1 parent 8da9852
commit cdc2824
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/pkg/errors/error.go b/pkg/errors/error.go
@@ -55,6 +55,9 @@ var (
 	// SecretTypeNotSupported is returned if non opaque secret is used.
 	SecretTypeNotSupported = fmt.Errorf(
 		"only opaque secrets can be used")
+	// SecretNotFound is returned if specified kubernetes secret is not found.
+	SecretNotFound = fmt.Errorf(
+		"kubernetes secret not found")
 )
 
 // AWSError returns the type conversion for the supplied error to an aws-sdk-go

diff --git a/pkg/runtime/reconciler.go b/pkg/runtime/reconciler.go
@@ -105,7 +105,7 @@ func (r *reconciler) SecretValueFromReference(
 	}
 	var secret corev1.Secret
 	if err := r.kc.Get(ctx, nsn, &secret); err != nil {
-		return "", err
+		return "", ackerr.SecretNotFound
 	}
 
 	// Currently we have only Opaque secrets in scope.
@@ -118,7 +118,7 @@ func (r *reconciler) SecretValueFromReference(
 		return valuestr, nil
 	}
 
-	return "", ackerr.NotFound
+	return "", ackerr.SecretNotFound
 }
 
 // Reconcile implements `controller-runtime.Reconciler` and handles reconciling