Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to ACK runtime v0.39.0, code-generator v0.39.1 #282

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ack-bot
Copy link
Collaborator

@ack-bot ack-bot commented Oct 10, 2024

Update to ACK runtime v0.39.0, code-generator v0.39.1



NOTE:
This PR increments the release version of service controller from v1.2.13 to v1.2.14

Once this PR is merged, release v1.2.14 will be automatically created for sagemaker-controller

Please close this PR, if you do not want the new patch release for sagemaker-controller


stdout for make build-controller:

building ack-generate ... ok.
==== building sagemaker-controller ====
Copying common custom resource definitions into sagemaker
Building Kubernetes API objects for sagemaker
Generating deepcopy code for sagemaker
Generating custom resource definitions for sagemaker
Building service controller for sagemaker
Generating RBAC manifests for sagemaker
Running gofmt against generated code for sagemaker
Updating additional GitHub repository maintenance files
==== building sagemaker-controller release artifacts ====
Building release artifacts for sagemaker-v1.2.14
Generating common custom resource definitions
Generating custom resource definitions for sagemaker
Generating RBAC manifests for sagemaker

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-bot ack-bot requested a review from surajkota as a code owner October 10, 2024 04:12
@ack-bot ack-bot added the prow/auto-gen PRs related to prow auto generation automation label Oct 10, 2024
@ack-bot ack-bot requested a review from ryansteakley as a code owner October 10, 2024 04:12
@ack-prow ack-prow bot requested a review from rd-pong October 10, 2024 04:12
Copy link

ack-prow bot commented Oct 10, 2024

@ack-bot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
sagemaker-verify-attribution 29d4869 link false /test sagemaker-verify-attribution
sagemaker-kind-e2e 29d4869 link true /test sagemaker-kind-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Member

@michaelhtm michaelhtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ack-prow ack-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 11, 2024
Copy link

ack-prow bot commented Oct 11, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ack-bot, michaelhtm
Once this PR has been reviewed and has the lgtm label, please assign rd-pong for approval by writing /assign @rd-pong in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged. prow/auto-gen PRs related to prow auto generation automation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants