add support for customizing log format #164
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erezo9
requested review from
tonynv,
andrew-glenn,
tlindsay42 and
a team
as code owners
|
@tonynv @andrew-glenn @tlindsay42 please approve merge and release if no changes are required |
drewmullen
approved these changes
Nov 18, 2024
There was a problem hiding this comment.
LGTM @tonynv @tlindsay42 @andrew-glenn if any of yall can merge then cut a new minor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request implements a requirement that we have with regards to changing the log format of the vpc flow log
Currently flow log default format only lists the ENI and not the VPCID
As we have several ENIs in each VPC it would be easier to summarize data using the VPCID field and therefore we need to use a custom format