Add value to optionally create namespace for fluent-bit #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add option to not create namespace, needed for deploying chart via helmfile
|
This PR is stale because it has been open 60 days with no activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Added fluentbit.createNamespace value defaulted to true, if set to false avoids creating the namespace. This is needed for deploying the chart via Helmfile. Deployment via Helmfile fails otherwise with an error that the namespace already exists. Using the Helmfile option to not create the namespace likewise results in an error that the namespace does not exist.
Testing: Deployed the forked chart successfully via helmfile
Documentation:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.