BugFix: Add support for both IPv4 and IPv6 connections #229
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
At my company we started using VPN that only works over IPv6. Since that we started seeing below errors when connecting:
Mainly played around and used chat GPT to make the above changes, so please let me know if they look fine with you.
Details
Updated the method
__get_host_address_info
to support returning both IPv4 and IPv6 address information.Modified the initializer to handle both IPv4 and IPv6 addresses.
__get_host_address_info
is called and its response is unpacked intohostport
andaddress_family
.AF_INET
for IPv4 andAF_INET6
for IPv6).hostport
which now correctly handles both address types.Motivation and Context
Testing
I've tried to connect both on new and old VPN and this snipped doesn't return an error anymore:
Screenshots (if appropriate)
Types of changes
Checklist
./build.sh
succeedspytest test/unit
and they are passing.