Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Thheinen/efs accesspoints #6381

Merged
merged 12 commits into from
Aug 14, 2024
Merged

Thheinen/efs accesspoints #6381

merged 12 commits into from
Aug 14, 2024

Conversation

mapk-amazon
Copy link
Contributor

"Clone" of #6359

Description of changes

Add support to specify EFS access points per issue #2337

Tests

  • Integration tests included in the develop.yaml as well as unit tests.

@mapk-amazon mapk-amazon requested review from a team as code owners August 5, 2024 10:04
dreambeyondorange
dreambeyondorange requested changes Aug 9, 2024
View reviewed changes
Copy link
Contributor

@dreambeyondorange dreambeyondorange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay. I think this PR looks great. Thanks for the contribution. I have a couple minor comments and once resolved I can approve!

cli/src/pcluster/schemas/cluster_schema.py Outdated Show resolved Hide resolved
cli/src/pcluster/validators/efs_validators.py Outdated Show resolved Hide resolved
cli/tests/pcluster/validators/test_efs_validators.py Outdated Show resolved Hide resolved
@dreambeyondorange
Copy link
Contributor

Approved but you need to rebase

@mapk-amazon mapk-amazon force-pushed the thheinen/efs-accesspoints branch from 83fbc10 to 80a3555 Compare August 10, 2024 10:26
@mapk-amazon
Copy link
Contributor Author

Rebased to the latest develop. Needed to rewrite the history a bit... Should now be up-to-date.

@dreambeyondorange dreambeyondorange merged commit 2543032 into aws:develop Aug 14, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dreambeyondorange dreambeyondorange dreambeyondorange approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mapk-amazon @dreambeyondorange @thheinen