Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: rest path resolution #3032

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

stobrien89
Copy link
Member

Issue #, if available:
#3030

Description of changes:
Fixes issue with non-s3 services (only Location V2 services currently) whose endpoint ruleset models a URI with a path.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@stobrien89 stobrien89 force-pushed the rest-path-resolution-fix branch 2 times, most recently from 6a37f60 to d3fcf88 Compare November 20, 2024 16:31
Copy link
Contributor

@yenfryherrerafeliz yenfryherrerafeliz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with just one question and one minor nit.

src/Api/Serializer/RestSerializer.php Show resolved Hide resolved
src/Api/Serializer/RestSerializer.php Outdated Show resolved Hide resolved
@stobrien89 stobrien89 force-pushed the rest-path-resolution-fix branch from d3fcf88 to 0326488 Compare November 21, 2024 18:08
@stobrien89 stobrien89 force-pushed the rest-path-resolution-fix branch from 0326488 to 9896706 Compare November 21, 2024 18:26
@stobrien89 stobrien89 merged commit 918e4ff into aws:master Nov 21, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants