-
Notifications
You must be signed in to change notification settings - Fork 983
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(chart): Improved default security context #7279
Open
stevehipwell
wants to merge
1
commit into
aws:main
Choose a base branch
from
stevehipwell:chart-security-context
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+40
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for karpenter-docs-prod canceled.
|
stevehipwell
force-pushed
the
chart-security-context
branch
from
November 4, 2024 15:42
e211a98
to
0e90ebf
Compare
stevehipwell
force-pushed
the
chart-security-context
branch
from
November 18, 2024 09:47
0e90ebf
to
dacfc30
Compare
@tzneal could you take a look at this please? |
This PR has been inactive for 14 days. StaleBot will close this stale PR after 14 more days of inactivity. |
stevehipwell
force-pushed
the
chart-security-context
branch
from
December 2, 2024 17:03
dacfc30
to
5cc1c72
Compare
@jonathan-innis @tzneal could someone please take a look at this? |
Signed-off-by: Steve Hipwell <[email protected]>
stevehipwell
force-pushed
the
chart-security-context
branch
from
December 12, 2024 10:43
5cc1c72
to
be44880
Compare
@jonathan-innis @tzneal could someone please take a look at this? |
I'll take a look at this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #N/A
Description
This PR improves the default security context posture and adds support for setting container values which should be user defined.
How was this change tested?
The Helm chart was templated with the new values.
Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.