fix: avoid selecting subnets with insufficient available IP address #7310
Conversation
✅ Deploy Preview for karpenter-docs-prod ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Vacant2333
force-pushed
the
feat-select-the-most-availalbe-ip-count-subnet
branch
from
22ed451 to
4348646
Compare
Vacant2333
changed the title
|
@jmdeal @jonathan-innis hi, can u help me review, this pr will resolve the issue #5234 |
|
This PR has been inactive for 14 days. StaleBot will close this stale PR after 14 more days of inactivity. |
Signed-off-by: Vacant2333 <[email protected]>
Vacant2333
force-pushed
the
feat-select-the-most-availalbe-ip-count-subnet
branch
from
4348646 to
d120906
Compare
|
@jmdeal can u help me reveiw? thanks |
|
@rschalo I know you're incredibly busy, but this PR would be a game-changer for us. It addresses the persistent issue we've been struggling with in #5234, and getting it merged would genuinely make a world of difference for our team. We're counting on your expertise to give it the green light. Thank you so much for considering this 🙏 |
|
Hi All - there is not currently a unit test around this behavior. Could we add one where we assert a subnet is no longer considered if IP exhaustion is expected? From a quick look I think it'd be tested via targeting one zone in a test for InstanceProvider create and an with update to the mock EC2 provider that adds a subnet with 0 available IPs for the targeted zone but not sure how that affects other tests. |
Fixes #5234
#2921
Description
its a feature that when launchInstance select the subnet which has the most available ip count.
How was this change tested?
Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.