Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run 'gofmt -w' over the code #18

Open
wants to merge 1 commit into
base: mainline
Choose a base branch
from
Open

Conversation

skwashd
Copy link

@skwashd skwashd commented Oct 24, 2021

Issue #, if available:

#17

Description of changes:

Ran gofmt -w src as instructed by checkstyle.sh. This unbreaks the build.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

@shaib shaib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this StackOverflow answer implies, this is needed for golang >=1.17

@realtime-neil
Copy link

@yuting-fan @Yangtao-Hua , this is a mechanical change that fixes the error in the makefile's default target. It would be great if you could take any action on this issue, even if to only comment that you're looking at it.

@Yangtao-Hua
Copy link
Contributor

Hi @skwashd
Thank you for the PR and it is really helpful. We noticed this issue, verified it happens when build with the new golang version. Related engineer is tracking and working on the fix, will release it after a through test.

Thanks,
Yangtao

@jayvdb
Copy link

jayvdb commented Apr 12, 2023

this PR isnt needed any more, but the same problem still exists and is fixed with #65

@jayvdb
Copy link

jayvdb commented Oct 26, 2024

@skwashd , this isnt needed. Recently reformatted in e3d6eeb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants