-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added darwin arm64 #44
base: mainline
Are you sure you want to change the base?
Conversation
I built this from source and tested this locally, it works on my machine^TM |
It would be worth reviewing https://github.com/aws/session-manager-plugin/pull/42/files which does a very similar thing and upgrades to a newer go version |
Could you send us the actual build? Who knows how long this pull request will be under review. Thanks in advance! |
@evgenytk #42 has a reply from @Yangtao-Hua its in their plan but not sure where. |
c3130ba
to
208c22e
Compare
208c22e
to
5e6f919
Compare
@evgenytk heres a release if you want to use it, and explicit instructions on usage: |
thank you a lot! |
We are actively working to add darwin-arm64 support and this change is currently under review. Will keep this thread updated on the release as we make progress. |
@nitikaaws @Yangtao-Hua :: Any progress on this issue? |
Any updates? |
Apologies for the delay in releasing the support for darwin-arm64! Our team is looking into this and will provide an update when we are closer to the release. |
@nitikaaws Any chance of a community release? You said you were reviewing this change in November. |
@nitikaaws It would be great if you could please provide us with an estimated date for when this will be available. We are investigating the option of using SSM within our engineering team and most of them use Mac M1. Thanks! |
Issue #, if available:
#26
Description of changes:
Added
Tools/src/create_darwin_arm64_bundle_plugin.sh
as a carbon copy ofTools/src/create_darwin_bundle_plugin.sh
, except all instances ofamd64
are replaced witharm64
.Moved the above script to
Tools/src/create_darwin_amd64_bundle_plugin.sh
to help differentiate between the two bundlers.Added targets for the
arm64
architecture to the makefile above every instance of theamd64
build steps for darwin.Renamed the bundler script in the makefile to use the new bundler script for
amd64
architectureBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Release for people that need to use it right now (note, my gofmt did not work, and govet is super annoyed at this, so i just turned that off before i built):
https://github.com/bleepbloopsify/session-manager-plugin/releases/tag/dev.macos.arm64