Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added darwin arm64 #44

Open
wants to merge 1 commit into
base: mainline
Choose a base branch
from

Conversation

bleepbloopsify
Copy link

@bleepbloopsify bleepbloopsify commented Jun 17, 2022

Issue #, if available:
#26

Description of changes:
Added Tools/src/create_darwin_arm64_bundle_plugin.sh as a carbon copy of Tools/src/create_darwin_bundle_plugin.sh, except all instances of amd64 are replaced with arm64.
Moved the above script to Tools/src/create_darwin_amd64_bundle_plugin.sh to help differentiate between the two bundlers.

Added targets for the arm64 architecture to the makefile above every instance of the amd64 build steps for darwin.

Renamed the bundler script in the makefile to use the new bundler script for amd64 architecture

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Release for people that need to use it right now (note, my gofmt did not work, and govet is super annoyed at this, so i just turned that off before i built):
https://github.com/bleepbloopsify/session-manager-plugin/releases/tag/dev.macos.arm64

@bleepbloopsify
Copy link
Author

bleepbloopsify commented Jun 17, 2022

I built this from source and tested this locally, it works on my machine^TM

@andymac4182
Copy link

It would be worth reviewing https://github.com/aws/session-manager-plugin/pull/42/files which does a very similar thing and upgrades to a newer go version

@evgenytk
Copy link

I built this from source and tested this locally, it works on my machine^TM

Could you send us the actual build? Who knows how long this pull request will be under review. Thanks in advance!

@andymac4182
Copy link

@evgenytk #42 has a reply from @Yangtao-Hua its in their plan but not sure where.

@bleepbloopsify
Copy link
Author

@evgenytk heres a release if you want to use it, and explicit instructions on usage:
https://github.com/bleepbloopsify/session-manager-plugin/releases/tag/dev.macos.arm64

@evgenytk
Copy link

@evgenytk heres a release if you want to use it, and explicit instructions on usage: https://github.com/bleepbloopsify/session-manager-plugin/releases/tag/dev.macos.arm64

thank you a lot!

@nitikaaws
Copy link
Contributor

We are actively working to add darwin-arm64 support and this change is currently under review. Will keep this thread updated on the release as we make progress.

@frodosghost
Copy link

@nitikaaws @Yangtao-Hua :: Any progress on this issue?

@shaul75
Copy link

shaul75 commented Jan 24, 2023

Any updates?

@nitikaaws
Copy link
Contributor

Apologies for the delay in releasing the support for darwin-arm64! Our team is looking into this and will provide an update when we are closer to the release.

@andymac4182
Copy link

@nitikaaws Any chance of a community release? You said you were reviewing this change in November.

@viniciusps
Copy link

@nitikaaws It would be great if you could please provide us with an estimated date for when this will be available. We are investigating the option of using SSM within our engineering team and most of them use Mac M1.

Thanks!

@nitikagoyal87
Copy link

Session Manager Plugin support for darwin-arm64 has been released with version 1.2.463.0. This pull request has been incorporated in 60f4fa7 commit. Thanks for your patience and support, please let us know your feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants