-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow setting of the local listener address #54
base: mainline
Are you sure you want to change the base?
Conversation
Please someone approve and merge. Please @Yangtao-Hua , @ziwangj ? |
Thank you for the changes, we are under review and further discussion. |
Any update? |
Thank you for the request! We evaluate new feature requests periodically based on our priority plans. We will provide an update when this request is picked up by the team. |
@bbankeAWS Thank you! Since this feature has already been implemented, as you can see in the 'Files changed' section above, I believe we don't need to discuss it extensively, and we can simply proceed with the code review. |
Friendly bump, this would benefit us a lot! |
Sure would be nice to be able to run AWS SSM via docker - this is a blocker for that. |
Please merge this PR, its a pain to use session manager in a Docker image right now. |
This feature is a must! It would be really great to see it working |
@bbankeAWS @ziwangj @Yangtao-Hua Hi, thank you for your review and the planning effort. Would you mind sharing what steps we can take to help make this feature available? |
@Yangtao-Hua , @ziwangj. Please respond. |
Closing in on 2 years for this one. |
@Yangtao-Hua @ziwangj Merry Christmas! How’s it going? Do you have any updates? |
This would be really useful for binding multiple connections to the same port on different loopback addresses. I would love to specify a Our use case looks like forwarding to multiple HTTPS hosts at once, and using local DNS overrides to make them accessible via their original hostnames. e.g.
Because of the harcoded localhost, our workaround is to run the SSM port forwarding inside docker, bridge the connection to another port inside docker via With the small change of supporting arbitrary bind addresses, we could remove docker & socat from our flow and have a far simpler experience. |
Issue #, if available:
#14 (slightly related)
Description of changes:
What:
This change introduces the ability to change the listener address, under which the port forwarding will listen. The default of
localhost
is kept.Why:
I am using a
PortForwardingSession
, which runs inside a GitLab CI Service. This allows me to abstract the forwarding logic away, and have it re-usable. However, since the forwarding session is not running "locally" anymore, it needs to be accessible from outside the service. With a listener address oflocalhost
, this is not possible. I am successfully using0.0.0.0
akin to whats written in Accessing forwarded port from Docker container #14, and this works flawlessly.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.