fix: Prevent global config of API Endpoint #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a bug where the AWS SDK session is configured to use a specific endpoint. This commit moves the endpoint configuration from the SDK Session to specific SDK Clients (SSM). The SSM endpoint is passed in to the session-manager-plugin from the AWS CLI, and I believe the intention is to ensure any Region overrides from the AWS CLI are respected by the session-manager-plugin. A problem occurs when the AWS credentials are sourced from AWS SSO / Identity Center. When the SDK Session is configured with an endpoint, this overrides all Service Endpoints, including SDK internal SSO credential providers. When the current SSO credentials need to be refreshed, the refresh request is sent to https://ssm.[aws-region].amazonaws.com/token. The SSM API does not know about the /token endpoint, or CreateToken operation, and returns an UnknownOperation error.
|
Hi @Yangtao-Hua are you able to review this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
Description of changes:
There is a bug where the AWS SDK session is configured to use a specific endpoint.
This commit moves the endpoint configuration from the SDK Session to specific SDK Clients (SSM).
The SSM endpoint is passed in to the session-manager-plugin from the AWS CLI, and I believe the intention is to ensure any Region overrides from the AWS CLI are respected by the session-manager-plugin.
A problem occurs when the AWS credentials are sourced from AWS SSO / Identity Center.
When the SDK Session is configured with an endpoint, this overrides all Service Endpoints, including SDK internal SSO credential providers. When the current SSO credentials need to be refreshed, the refresh request is sent to
https://ssm.[aws-region].amazonaws.com/token. The SSM API does not know about the /token endpoint, or CreateToken operation, and returns an UnknownOperation error.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.