Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Google AI agent and classifier #170

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Conversation

slavb18
Copy link

@slavb18 slavb18 commented Dec 24, 2024

Issue number:

Summary

Changes

Provide agent and classifier for GoogleGenerativeAI client

User experience

User experience not changed

Checklist

If your change doesn't seem to apply, please leave them unchecked.

  • I have performed a self-review of this change
  • Changes have been tested
  • Changes are documented

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@cornelcroi
Copy link
Contributor

Thank you @slavb18 for the PR.

1 - Could you create a documentation page for the classifier and for the agent with some code examples on how to create an agent/classifier with different options?
You can use this one as example.
2 - Also, maybe you could adding a script with a couple of agents (google agents and/or other agents) and google classifier somewhere in example folder. Examples are always a good.

@cornelcroi
Copy link
Contributor

Thanks for the update.
In the documentation I see the python version but in the PR I see only changes to typescript.
Do you plan to add the python version to this PR?

@slavb18
Copy link
Author

slavb18 commented Dec 24, 2024

Thanks for the update.
In the documentation I see the python version but in the PR I see only changes to typescript.
Do you plan to add the python version to this PR?

Thank you for pointing that out! I prefer to submit the TypeScript version only, if this is applicable, to keep the scope of the PR focused. Additionally, since there is no toolagent support currently, it would need to be added first before implementing the Python version. Let me know how you’d like to proceed!

@cornelcroi
Copy link
Contributor

Ok, sure.
In this case I would suggest to delete the <TabItem label="Python" icon="seti:python"> from the doc, in this case it will be a single tab with typescript code.

@cornelcroi
Copy link
Contributor

cornelcroi commented Dec 24, 2024

For python we will publish in the following days a simplified way to use tools with agents.
You can use tools today but it is a bit ugly the code required, so we simplified.
You could wait for it, and then create the python version with tools support also.

@slavb18 slavb18 changed the title Google AI agent and classifier WIP: Google AI agent and classifier Dec 25, 2024
@slavb18 slavb18 marked this pull request as draft December 25, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants