Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed the issue when DEM couldn't find the existing repositories. #208

Merged
merged 1 commit into from
Sep 12, 2024
Merged

Fixed the issue when DEM couldn't find the existing repositories. #208

merged 1 commit into from
Sep 12, 2024

Conversation

janosmurai
Copy link
Contributor

@janosmurai janosmurai commented Sep 12, 2024 •
edited by jira bot
Loading

Type Of Change

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Any modification in the test cases
  • Any modification in the documentation

Checklist:

  • I have read and followed the contribution guideline.
  • I have checked to ensure there aren't other open Pull Requests for the same update/change.
  • All the test cases pass and new modifications in the production code are 100% covered.
  • I have made corresponding changes to the documentation.

Related Issue

Closing:
DEM-289

Description

DEM couldn't find the images available from the registries, because it loaded
the repo information without the namespece (DockerHub) and URL (other registries)
information. The fix was to prepend these information when updating the Registry
classes.

How Has This Been Tested?

Tested on Ubuntu 22.04

@janosmurai
The repo information obtained from the registries gets saved in the same
15c6be7 
format as they are managed by Docker. Meaning for DockerHub repos
{namespace}/{name}:{tag} for other registries {url}/{name}:{tag}.
@janosmurai janosmurai requested a review from a team as a code owner September 12, 2024 09:32
@janosmurai janosmurai merged commit cf41094 into axem-solutions:main Sep 12, 2024
1 check passed
@janosmurai janosmurai deleted the DEM-289 branch September 12, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vezdeneszter vezdeneszter Awaiting requested review from vezdeneszter vezdeneszter is a code owner automatically assigned from axem-solutions/persea

@magyta93 magyta93 Awaiting requested review from magyta93 magyta93 is a code owner automatically assigned from axem-solutions/persea

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@janosmurai