Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Information about tool images available from the added registries are retrieved only when needed #224

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

janosmurai
Copy link
Contributor

@janosmurai janosmurai commented Oct 8, 2024

Type Of Change

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Any modification in the test cases
  • Any modification in the documentation

Checklist:

  • I have read and followed the contribution guideline.
  • I have checked to ensure there aren't other open Pull Requests for the same update/change.
  • All the test cases pass and new modifications in the production code are 100% covered.
  • I have made corresponding changes to the documentation.

Related Issue

Closing:
#202
DEM-283

Description

The list of tool images available from the registries is needed in the following cases:

  • The user would like to create a new DevEnv. On the DevEnv Settings Window, the available tools should be listed.
  • The user would like to modify a DevEnv. Again, the available tool images are needed on the DevEnv Settings Window.
  • The user wants to list the tool images from the registries with the dem list-tools --reg command.

For the rest of the use cases where the registry information used to be loaded is now cleaned up, so DEM's overall speed increased.

This change allows the DevEnv installation to be executed even if there are tool images that should be pulled from registries not added to DEM.

How Has This Been Tested?

It was tested on Ubuntu 22.04, by trying out the commands.

@janosmurai janosmurai requested a review from a team as a code owner October 8, 2024 15:49
@janosmurai janosmurai merged commit e96d2f6 into axem-solutions:main Oct 8, 2024
1 check passed
@janosmurai janosmurai deleted the DEM-283 branch October 8, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant