Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new 11.4 dev-pipeline #30

Merged
merged 7 commits into from
Jul 23, 2024
Merged

Use new 11.4 dev-pipeline #30

merged 7 commits into from
Jul 23, 2024

Conversation

ivy-rew
Copy link
Member

@ivy-rew ivy-rew commented Jul 23, 2024

Update pipelines to v3 which are aware of the capabilities of 11.4: This change should serve as sample how to update other market-artifacts to comply with the ivy-core:11.4

  • introduces a property to steer the project.build.plugin.version and tester.version
  • adds snapshot repositories to the POM's in order to consume SNAPSHOT artifacts during dev-pipeline runs
  • upgrade the versions to the latest available from 10.X using the maven cli command line:
  • mvn --batch-mode versions:set-property versions:commit -Dproperty=project.build.plugin.version -DnewVersion=10.0.16 -DallowSnapshots=true
  • mvn --batch-mode versions:set-property versions:commit -Dproperty=tester.version -DnewVersion=10.0.16 -DallowSnapshots=true

for traceability I'd love to see this taken as receipt, also in terms of its history. each change is an own commit. manual and automated changes come separate.

  • if you need to build a hack to comply with 11.4, please isolate it in a distinct commit, and create an issue for it, just like I did it by example on The APIkey variable is defined in an invalid format #32 . You can than plan to actually introduce distinct versions targeting leading-edge releases, to get rid of such technical depts. Ask @ivy-sgi to plan these efforts.

This reverts commit 53242e2.

Copy link
Contributor

github-actions bot commented Jul 23, 2024

Test Results

3 tests  ±0   0 ✅ ±0   5s ⏱️ -2s
1 suites ±0   0 💤 ±0 
1 files   ±0   0 ❌  - 3   3 🔥 +3 

For more details on these errors, see this check.

Results for commit 8cafd1b. ± Comparison against base commit 846d01a.

♻️ This comment has been updated with latest results.

@ivy-rew ivy-rew marked this pull request as ready for review July 23, 2024 09:00
@ivy-rew ivy-rew changed the title Revert "Update dev.yml to use nightly-10" Use new 11.4 dev-pipeline Jul 23, 2024
@ivy-rew
Copy link
Member Author

ivy-rew commented Jul 23, 2024

the build still fails as @ivy-sgi already found out, this is due the invalid URI in use which is reported as #28.
it's good to get feedback on this problem, though we should maintain a mock-server, just like for every other soap/rest connector., so we can test without running into infrastructure problem with the third-party.

ivy-rew added 2 commits July 23, 2024 11:24
- though we should introduce a new version for 11.4 with a compatible api-key.
Copy link

@phhung-axonivy phhung-axonivy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good.
Should I merge it?

@ivy-rew ivy-rew merged commit 1603168 into master Jul 23, 2024
2 of 3 checks passed
@ivy-rew ivy-rew deleted the dev114 branch July 23, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants