Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sustain pedal #532

Draft
wants to merge 5 commits into
base: midi
Choose a base branch
from
Draft

sustain pedal #532

wants to merge 5 commits into from

Conversation

SiriusZael
Copy link
Collaborator

  • WIP — MIDI support
  • WIP
  • fix build
  • fix tests
  • WIP

@SiriusZael SiriusZael changed the base branch from main to midi May 24, 2023 19:06
@bencbartlett
Copy link
Collaborator

This looks good -- now that you have this set up, would it be possible to modify it to include the following information?

struct MidiInfo {
    int sustainPedalCount, // number of times pedal has been pressed in current session
    bool sustainPedalActive, // whether the pedal is pressed 
    int notesCount, // number of notes which have been pressed in current session
    bool notesActive[88], // 88 size array of whether each note is currently pressed 
    int notesVelocities[88], // 88 size array of note velocities which are currently pressed  
}

@xian I don't have write access to the master branch; it would be great if we could merge this before the tech test next weekend. I will be out of town but I can write a test shader and give @SiriusZael the necessary equipment/cables to test all of this.

@xian
Copy link
Member

xian commented Aug 1, 2023

@xian I don't have write access to the master branch

Oops, sorry about that, added you as a maintainer @bencbartlett!

@xian
Copy link
Member

xian commented Aug 1, 2023

@SiriusZael — when you're ready could you rebase to take out the 'WIP's in commit comments? I know I've got a couple in there too on midi.

@xian
Copy link
Member

xian commented Aug 1, 2023

struct MidiInfo {
    ...
    bool notesActive[88], // 88 size array of whether each note is currently pressed 
    int notesVelocities[88], // 88 size array of note velocities which are currently pressed  
}

IIRC glsl arrays aren't well supported by sparklemotion yet so this might be a bit involved. Happy to help on it though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants