tests: tallying and block finalization #446
Conversation
There was a problem hiding this comment.
The code lgtm. Somehow the e2e test failed though.
--- FAIL: TestConsumerFpLifecycle (0.02s)
babylon_node_handler.go:145:
Error Trace: /home/circleci/project/itest/babylon_node_handler.go:145
/home/circleci/project/itest/cosmwasm/bcd/bcd_test_manager.go:66
/home/circleci/project/itest/cosmwasm/bcd/bcd_consumer_e2e_test.go:32
Error: Received unexpected error:
exec: "babylond": executable file not found in $PATH
Test: TestConsumerFpLifecycle
FAIL
FAIL github.com/babylonchain/finality-provider/itest/cosmwasm/bcd 0.226s
ok github.com/babylonchain/finality-provider/keyring 0.964s
FAIL
maybe somehow babylond is not installed?
itest/bytecode/version.txt
Outdated
There was a problem hiding this comment.
i intend to use a newer commit than the tagged one, maybe once we have the next release in babylon-contract i'll bump the version here as well
| @@ -37,6 +37,7 @@ func NewBcdNodeHandler(t *testing.T) *BcdNodeHandler { | |||
|
|
|||
| setupBcd(t, testDir) | |||
There was a problem hiding this comment.
This requires that bcd is built and installed. Let's use a submodule for it, along with a commit / tag reference, and add the build instructions to the test and test-e2e targets.
For the test-e2e test targets, perhaps a series of docker images is better. But I think this is OK for now.
There was a problem hiding this comment.
This requires that bcd is built and installed
bcd command is installed using make target then later the node is started using bcd cli
Let's use a submodule for it, along with a commit / tag reference, and add the build instructions to the test and test-e2e targets.
not sure if i got this properly, can you elaborate how would a submodule be used here? Docker image is a good idea similar to the way tests are done in babylon repo, but this requires major refactoring
There was a problem hiding this comment.
I mean, similar to how babylon-deployment works. But instead of compiling a docker image using the build-docker target in the sub-module, you just issue make build && make install.
Not sure this is the right approach / place to do this though. Perhaps these tests, which are a kind of integration / e2e test, should live in the babylon-deployment repo instead.
There was a problem hiding this comment.
have opened a issue to track this probably will be done in a separate pr
#477
|
Tests are broken atm. Contracts seems to be deployed into the wrong chain (Babylon chain instead of |
…o gusin13/tallying-works
contract is deployed on bcd ref, the problem seems to be something else. The bcd cmd package is not being installed properly in ci jobs, if I run the tests locally they are passing. On my local I manually install the bcd by cloning babylon-sdk and then make install the tests pass, but if i use If the package is install using go install (like its done in ci jobs), then if its done manually using make install (by cloning babylon-sdk and cd babylon-sdk then make install) trying to debug why this is happening |
|
@gusin13 op tests failed likely due to rate limiting querying BTC mainnet RPCs. we fixed it already to mock the RPC client. after you rebase, it should be fixed |
This pr adds necessary assertions and code needed to make sure tallying and block finalization works
https://github.com/babylonchain/babylon-deployment/pull/99#issuecomment-2193909123