Update CKEditor plugin.js to detect window border and set position #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Like classic library, we look if the bottom of the window is not too close. If it is, we set the position above.
|
Not sure if the code works nicely, seems to have some problems randomly, but the idea is to get the same system as the classic library. hope you understand what i mean... |
Some modifications, still some problems of offset on position above.
Seems to work fine now, but didn't test deeply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like classic library, we look if the bottom of the window is not too close. If it is, we set the position above.
It's a problem if the CKEditor is really near the window border. Could be improved with sides detection and offset.