Skip to content

Commit

Permalink
compose: core: remove /dev:/dev binding
Browse files Browse the repository at this point in the history
Binding the host's devtmpfs inside a container, especially in
combination with `privileged: true` has a high likelyhood of tampering
with host device permissions and nodes. Remove it.

Change-type: patch
Signed-off-by: Joseph Kogut <[email protected]>
  • Loading branch information
jakogut committed Jan 31, 2024
1 parent 4b8749e commit b55c71f
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions docker-compose.client.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,6 @@ services:
- /var/run # use tmpfs docker-in-docker pid files
- /var/lib/docker # use tmpfs for docker-in-docker data root
restart: 'no'
devices:
- /dev:/dev # required for creating losetup devices during preload

volumes:
core-storage:
Expand Down

0 comments on commit b55c71f

Please sign in to comment.