core: gzip before sending the os image to reduce frequency of timeouts #1120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rcooke-warwick
force-pushed
the
ryan/gzip-first
branch
from
2768974 to
95f9a90
Compare
rcooke-warwick
force-pushed
the
ryan/gzip-first
branch
from
95f9a90 to
499e7c7
Compare
| @@ -135,6 +135,10 @@ module.exports = class Worker { | |||
| * @category helper | |||
| */ | |||
| async flash(imagePath) { | |||
|
|
|||
| this.logger.log(`Gzipping image...`); | |||
| await exec(`gzip ${imagePath}`); | |||
There was a problem hiding this comment.
Instead of adding another OS dependency I was thinking if the entire problem is gzipping in the request causes a timeout then why not use the same logic to gzip out of the request something like
Create a temp file
pipeline(
fs.createReadStream(imagePath),
createGzip({ level: 6 }),
tempFile
)
await move(tempfile, imagePath) // https://stackoverflow.com/a/34499859
This should also unlink/overrwite the image on imagePath
rcooke-warwick
force-pushed
the
ryan/gzip-first
branch
from
499e7c7 to
773540a
Compare
Change-type: patch Signed-off-by: Ryan Cooke <[email protected]>
rcooke-warwick
force-pushed
the
ryan/gzip-first
branch
from
773540a to
abee0a7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
balena-os/leviathan-worker#101 - corresponding worker PR with context
Change-type: patch