Download BalenaOS images from URL #1132
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| function isUrl(filePath) { | ||
| let pattern = new RegExp('^(https?:\\/\\/)?' + // protocol | ||
| '(\\S+\\:\\S+@)?' + // optional user:pass authentication | ||
| '((([a-z\\d]([a-z\\d-]*[a-z\\d])*)\\.)+[a-z]{2,}|' + // domain name |
Check failure
Code scanning / CodeQL
Inefficient regular expression High
| function isUrl(filePath) { | ||
| let pattern = new RegExp('^(https?:\\/\\/)?' + // protocol | ||
| '(\\S+\\:\\S+@)?' + // optional user:pass authentication | ||
| '((([a-z\\d]([a-z\\d-]*[a-z\\d])*)\\.)+[a-z]{2,}|' + // domain name |
Check failure
Code scanning / CodeQL
Inefficient regular expression High
| function isUrl(filePath) { | ||
| let pattern = new RegExp('^(https?:\\/\\/)?' + // protocol | ||
| '(\\S+\\:\\S+@)?' + // optional user:pass authentication | ||
| '((([a-z\\d]([a-z\\d-]*[a-z\\d])*)\\.)+[a-z]{2,}|' + // domain name |
Check failure
Code scanning / CodeQL
Inefficient regular expression High
vipulgupta2048
force-pushed
the
vipulgupta2048/download-url
branch
from
90dbe45 to
3f5ff3a
Compare
Signed-off-by: Vipul Gupta (@vipulgupta2048) <[email protected]>
Signed-off-by: Vipul Gupta (@vipulgupta2048) <[email protected]>
vipulgupta2048
force-pushed
the
vipulgupta2048/download-url
branch
from
3f5ff3a to
999db4d
Compare
Signed-off-by: Vipul Gupta (@vipulgupta2048) <[email protected]>
vipulgupta2048
force-pushed
the
vipulgupta2048/download-url
branch
from
999db4d to
5d3fc08
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR enables the use of an image URL in the config.js of the test suite for it to be later used to download a BalenaOS image.