Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop use of legacy compose binary #1252

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

klutchell
Copy link
Collaborator

@klutchell klutchell commented Nov 21, 2024

This reverts commit be4130f which pinned docker-compose to v2.3.3 in order to properly support the device_cgroup_rules directive.

This should be supported natively by compose v2.

See: docker/compose@d8775c7
See: docker/compose#9059
See: be4130f

@klutchell klutchell temporarily deployed to bm.balena-dev.com November 21, 2024 14:29 — with GitHub Actions Inactive
@klutchell klutchell temporarily deployed to bm.balena-dev.com November 21, 2024 14:29 — with GitHub Actions Inactive
@klutchell klutchell marked this pull request as ready for review November 22, 2024 14:15
@klutchell klutchell requested a review from jakogut November 22, 2024 14:15
@flowzone-app flowzone-app bot enabled auto-merge November 22, 2024 14:20
@klutchell klutchell temporarily deployed to bm.balena-dev.com November 22, 2024 14:20 — with GitHub Actions Inactive
@klutchell klutchell temporarily deployed to bm.balena-dev.com November 22, 2024 14:20 — with GitHub Actions Inactive
This reverts commit be4130f which pinned docker-compose to v2.3.3
in order to properly support the device_cgroup_rules directive.

This feature is supported by compose v2.3.3 to v2.30.3 and above.

Change-type: patch
Signed-off-by: Kyle Harding <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants