Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete legacy PM usage #103

Closed
wants to merge 4 commits into from
Closed

delete legacy PM usage #103

wants to merge 4 commits into from

Conversation

FinleyTang
Copy link
Contributor

when enable legacy PassManager with the following command: opt-17 -enable-new-pm=0 -load ./libHelloWorld.so -legacy-hello-world -disable-output input_for_hello.ll there is an error: opt-17: Unknown command line argument '-enable-new-pm=0'. Try: 'opt-17 --help',
image

using --bugpoint-enable-legacy-pm can solve this.
image

when enable legacy PassManager with the following command:
opt-17 -enable-new-pm=0 -load ./libHelloWorld.so -legacy-hello-world -disable-output input_for_hello.ll
there is an error: opt-17: Unknown command line argument '-enable-new-pm=0'. Try: 'opt-17 --help',

using --bugpoint-enable-legacy-pm can solve this.
image
@banach-space
Copy link
Owner

Hi @FinleyTang , thanks for preparing this PR 🙏🏻 . As the legacy PM is being deprecated, I think that it would make more sense to simply delete that comment and any references to it. Would you mind updating this PR accordingly?

Thank you,
Andrzej

@FinleyTang FinleyTang changed the title Error encountered when enabling legacy PassManager and Its resolution delete legacy PM usage Nov 19, 2023
@FinleyTang
Copy link
Contributor Author

Hi @FinleyTang , thanks for preparing this PR 🙏🏻 . As the legacy PM is being deprecated, I think that it would make more sense to simply delete that comment and any references to it. Would you mind updating this PR accordingly?

Thank you, Andrzej

Certainly, if you think that retaining the legacy PM usage method is meaningless, we can remove it.

@FinleyTang
Copy link
Contributor Author

Hi @FinleyTang , thanks for preparing this PR 🙏🏻 . As the legacy PM is being deprecated, I think that it would make more sense to simply delete that comment and any references to it. Would you mind updating this PR accordingly?
Thank you, Andrzej

Certainly, if you think that retaining the legacy PM usage method is meaningless, we can remove it.

I have submitted another commit, deleting the usage method for the legacy PM.

@banach-space
Copy link
Owner

Hi @FinleyTang , thanks for preparing this PR 🙏🏻 . As the legacy PM is being deprecated, I think that it would make more sense to simply delete that comment and any references to it. Would you mind updating this PR accordingly?
Thank you, Andrzej

Certainly, if you think that retaining the legacy PM usage method is meaningless, we can remove it.

I have submitted another commit, deleting the usage method for the legacy PM.

You can also delete the implementation - it won't be needed moving forward. Thanks!

@FinleyTang FinleyTang closed this Nov 19, 2023
@FinleyTang FinleyTang deleted the FinleyTang-patch-1 branch November 19, 2023 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants