fix checking of existing bridges #54
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The comment states "Check to see if >any< bridges exist[...]", while it actually checks for the hard-coded bridges "bridge0" and "bridge1". This causes iocell to always create those two bridges if present bridges on the system have other names. Because the default route interface is being added to 'bridge0', the interface resets and drops all connections - on a jailhost this might be the default mgmt interface which carries the connection over which iocell was invoked and thus being terminated in the middle of starting the jail. This Fix changes the grep'ing for bridge0|bridge1 to simply checking for interfaces belonging to the 'bridge' group via 'ifconfig -g bridge'.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The comment at line 92ff states "Check to see if >any< bridges exist[...]", while it actually checks for the hard-coded bridges "bridge0" and "bridge1". This causes iocell to always create those two bridges if present bridges on the system have other names.
Because the default route interface is being added to 'bridge0', the interface resets and drops all connections - on a jailhost this might be the default mgmt interface which carries the connection over which iocell was invoked and thus being terminated in the middle of starting the jail.
This Fix changes the grep'ing for bridge0|bridge1 to simply checking for interfaces belonging to the 'bridge' group via 'ifconfig -g bridge'.
Make sure to follow and check these boxes before submitting a PR! Thank you.
Supply documentation according to CONTRIBUTING.md
bugfix; no update to documentation required
Explain the feature
fixes the behavior of how iocell checks for bridges and decides if it creates the default bridge0 and bridge1
Read CONTRIBUTING.md
Only open the PR against the
developbranch.