Finish ENSIP-19 integration #95
Conversation
🟡 Heimdall Review Status
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
Slither found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
|
Review Error for HandyPicklesStudioz @ 2024-10-02 04:17:46 UTC |
| uint256 discount; | ||
| } | ||
|
|
||
| struct URCStorage { |
| /// @param reverseRegistrar_ The reverse registrar contract. | ||
| /// @param owner_ The permissioned address initialized as the `owner` in the `Ownable` context. | ||
| /// @param rootNode_ The node for which this registrar manages registrations. | ||
| /// @param rootName_ The name of the root node which this registrar manages. |
There was a problem hiding this comment.
Natspec missing for params:
address paymentReceiver_,
address legacyRegistrarController_,
address reverseResolver_
| view | ||
| returns (uint256 price) | ||
| { | ||
| URCStorage storage $ = _getURCStorage(); |
There was a problem hiding this comment.
This could be done in a single line since $ is only called once in this function
There was a problem hiding this comment.
Leaving these up to discussion, non-blocking. This is more of a code-style question for consistency.
| /// | ||
| /// @param name The specified name. | ||
| /// @param resolver The resolver to set the reverse record on. | ||
| /// @param owner The owner of the reverse record. |
There was a problem hiding this comment.
Missing natspec for params:
uint256 expiry,
bytes memory signature
| bytes memory signature | ||
| ) internal { | ||
| URCStorage storage $ = _getURCStorage(); | ||
| // vesitigial reverse resolution |
There was a problem hiding this comment.
typo: vesitigial -> vestigial
|
Review Error for cb-elileers @ 2024-10-11 00:10:04 UTC |
|
Review Error for OKEAMAH @ 2024-10-22 23:41:40 UTC |
No description provided.