Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-introduce Safe interface, and remove from function signatures #104

Merged
merged 3 commits into from
Oct 29, 2024
Merged

Re-introduce Safe interface, and remove from function signatures #104

merged 3 commits into from
Oct 29, 2024

Conversation

mdehoog
Copy link
Contributor

@mdehoog mdehoog commented Oct 29, 2024

#102 removed the IGnosisSafe due to incompatibilities with optimism's interface.

This PR reverts that PR, and removes the IGnosisSafe from any function parameters (replacing with address) so we can be maximally compatible.

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Oct 29, 2024 •
edited
Loading

✅ Heimdall Review Status

Requirement Status More Info
Reviews ✅ 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@mdehoog mdehoog merged commit 12afb9f into main Oct 29, 2024
2 checks passed
@mdehoog mdehoog deleted the michael/safe-interface branch October 29, 2024 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevieraykatz stevieraykatz stevieraykatz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mdehoog @cb-heimdall @stevieraykatz