Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct type next #107

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Correct type next #107

wants to merge 5 commits into from

Conversation

savvar9991
Copy link

@savvar9991 savvar9991 commented Nov 27, 2024 •
edited
Loading

1. SECURITY.md

  • Improved phrasing in bug bounty program description: 
    - to cover the Base network
+ to include the Base network

- Coinbase's bug bounty program
+ Coinbase bug bounty program

2. foundry.toml

  • Standardized array formatting: 
    - fs_permissions = [ {access = "read-write", path = "./"} ]
+ fs_permissions = [{access = "read-write", path = "./"}]

3. remappings.txt

  • Improved readability of dependency mappings: 
    - @eth-optimism-bedrock/=lib/optimism/packages/contracts-bedrock/
+ @eth-optimism-bedrock/ = lib/optimism/packages/contracts-bedrock/

- @openzeppelin/contracts/=lib/openzeppelin-contracts/contracts
+ @openzeppelin/contracts/ = lib/openzeppelin-contracts/contracts

4. src/Vetoer1of2.sol

  • Fixed typos in comments: 
    - /// @notice The address of counter party's signer
+ /// @notice The address of counterparty's signer

- /// @notice Thrown when calling 'veto()' from an unhautorized signer
+ /// @notice Thrown when calling 'veto()' from an unauthorized signer

@savvar9991
Fixed syntax Vetoer1of2.sol
ee2ad0a 
Fixed a typo "Counter Party" → "Counterparty".
Fixed a typo "Unhautorized" → "Unauthorized".
Fixed syntax of the function of Address.functionCall ().
@savvar9991
correst typo README.md
7de22ef
@savvar9991
correct SECURITY.md
5e91ded 
Replaced "Cover" with "Include" for greater accuracy.
He removed excess commas and improved readability.
He reformulated "Assurn" in "Ensurg" to improve grammar.
Small stylistic improvements for better sound sound.
@savvar9991
correct foundry.toml
52b5e46 
fix
@savvar9991
fix remappings.txt
7e63ae3 
In some configuration formats, it is recommended to add gaps before and after the sign of equality to improve readability
@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Nov 27, 2024 •
edited
Loading

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@savvar9991 @cb-heimdall