Optional SAFE_NONCE variable fix #56
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdehoog
previously approved these changes
Jan 12, 2024
mdehoog
reviewed
Jan 12, 2024
cb-heimdall
dismissed
mdehoog’s stale review
Approved review 1817423593 from mdehoog is now dismissed due to new commit. Re-request for approval.
|
Review Error for OKEAMAH @ 2024-10-22 23:40:32 UTC |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The way we were using
envOrto take inSAFE_NONCEas an optional argument was not compiling. After fixing, it was causing other issues across the codebase because we were using aenvOrwhich was not marked as a view function in view functions. I checked with the foundry team and looks like this was an oversight so I upstreamed a change to makeenvOraviewfunction:This now compiles & works (if you run into issues, try running
make depswhich should pull the latest forge-std version).