Adds confirmation code #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
amhedcb
commented
Sep 25, 2024
| @@ -0,0 +1,28 @@ | |||
| name: Run Tests | |||
There was a problem hiding this comment.
Adding some github actions so we can run tests up here as well
Comment on lines
-39
to
-43
| if (!['eip681', 'contractCall', 'eip712'].includes(payloadType)) { | ||
| return res.status(400).json({ message: 'Invalid payload type, must be eip681 or contractCall' }); | ||
| } | ||
|
|
||
| const paymentUuid = uuid || uuidv4(); |
There was a problem hiding this comment.
Moved all these checks to the service, and defined proper types for them. IN case we ever need to deserialize (asked Cursor for help)
| dappName: payload.dappName, | ||
| payloadType: payload.payloadType, | ||
|
|
||
| additionalPayload: payload.additionalPayload, |
There was a problem hiding this comment.
Shouldn't this be thrown into txParams as well?
There was a problem hiding this comment.
I think I should store this one as it's own column, wdyt
There was a problem hiding this comment.
Hmm yeah I guess its own column makes sense
- Configure tests and simple-git-hooks - Update jest to latest
- Simplify DB schema - Refactoring code on API controllers - Debugging with Postman - Adds payload types
- Adds additionalPayload column - Fixes all tests - Configures github actions for running tests on PRs - Remove simple-git-hooks. Was causing an error on git pipeline
amhed
force-pushed
the
amhed/confirmation-code
branch
from
7f2e6b0 to
1920b59
Compare
justin-lee-cb
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still Pending
formatTxDataResponseandformatTxMessageResponse