Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔧 Fix CHANGELOG #107

Merged
merged 2 commits into from
Sep 20, 2023
Merged

🔧 Fix CHANGELOG #107

merged 2 commits into from
Sep 20, 2023

Conversation

Sabnock01
Copy link
Contributor

Fixes incorrect release versions in CHANGELOG.md.

@vercel
Copy link

vercel bot commented Sep 17, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
op-viem-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 20, 2023 6:08am

@Sabnock01 Sabnock01 temporarily deployed to verify September 17, 2023 23:15 — with GitHub Actions Inactive
@wilsoncusack
Copy link
Collaborator

were these actually all off by 1? 🤔 we have some PRs to automate this flow and improve

@Sabnock01
Copy link
Contributor Author

Sabnock01 commented Sep 17, 2023 •
edited
Loading

were these actually all off by 1? 🤔 we have some PRs to automate this flow and improve

2 was missing and 5 was present twice.

Versions listed were:

  • 0.0.1-alpha.5
  • 0.0.1-alpha.5
  • 0.0.1-alpha.4
  • 0.0.1-alpha.3
  • 0.0.1-alpha.1
  • 0.0.1-alpha.0

@wilsoncusack
Copy link
Collaborator

ok, 6 is also missing but doesn't have to be solve here

wilsoncusack
wilsoncusack requested changes Sep 19, 2023
View reviewed changes
Copy link
Collaborator

@wilsoncusack wilsoncusack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually, given 6 is missing, we should sanity check that all of these actually have the changes they say they do. E.g is writeFinalize... in 5 ?

wilsoncusack
wilsoncusack reviewed Sep 20, 2023
View reviewed changes
CHANGELOG.md Outdated
@@ -6,19 +6,19 @@

- Export writeFinalizeWithdrawTransaction and fix getProveWithdrawalTransactionArgs

## 0.0.1-alpha.5
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Sabnock01 I think read finalizedWithdrawals first shows up here https://www.npmjs.com/package/op-viem/v/0.0.1-alpha.5?activeTab=code

I think possibly .2 was a no-op and the latest should have been .6, matching https://www.npmjs.com/package/op-viem/v/0.0.1-alpha.5?activeTab=versions

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it. So the only issue was the most recent was incorrectly labeled .5 instead of .6.

@Sabnock01 Sabnock01 temporarily deployed to verify September 20, 2023 06:08 — with GitHub Actions Inactive
@wilsoncusack wilsoncusack merged commit 17776c4 into base-org:main Sep 20, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roninjin10 roninjin10 roninjin10 approved these changes

@wilsoncusack wilsoncusack wilsoncusack approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Sabnock01 @wilsoncusack @roninjin10