-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📝 docs: organize config.mts #108
📝 docs: organize config.mts #108
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Decided |
Thanks for this! I was unsure if we wanted to expose |
site/.vitepress/config.mts
Outdated
text: 'General', | ||
items: [ | ||
{ | ||
text: 'resolveL1OpStackContractAddress', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is internal and we don't need to export
I am fine with exporting |
ok, let's do that then. I also wonder if writeOpStackL1Contract might be a more clear naming. |
I think it is. Want to rename to both |
@Sabnock01 I am open to this but let's make it a different PR. Maybe this one can just be the reorg and we can punt on writeOpStackL1 and plan to not have docs or export |
simulateWithdrawERC20
Let me know if we prefer another name to the
General
category underUtilities
for functions likeresolveL1OpStackContractAddress
.