Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyspaces and Sidebar command Improvements #77

Merged
merged 11 commits into from
Nov 12, 2024

Conversation

rosajsx
Copy link
Contributor

@rosajsx rosajsx commented Nov 12, 2024

This pull request includes changes in the keyspace details page, keyspace table page, and sidebar command instructions.

ADDED

  • New KeyspaceConnectionNotFound component to keyspaces components
  • Validation on keyspace details and keyspace table detail to show a 'not found or connected message' when the connection was not selected.
  • Validation on keyspace details and keyspace table detail when keyspace data are loading.
  • Validation on keyspace details to show a 'not found message' when we try to access an unexisting keyspace on the current connection.
  • Validation on keyspace table detail to show a 'not found message' when we try to access an unexisting table on the current keyspace.
  • New contributor to contributor list on package.json

CHANGED

  • Status of Data Visualization feature from wip to done

@rosajsx rosajsx marked this pull request as ready for review November 12, 2024 18:17
danielhe4rt
danielhe4rt previously approved these changes Nov 12, 2024
src/app/(main)/page.tsx Outdated Show resolved Hide resolved
src/app/(main)/page.tsx Outdated Show resolved Hide resolved
@gvieira18 gvieira18 merged commit 3cbe00c into basementdevs:main Nov 12, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants