-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI Improvements #87
Merged
Merged
UI Improvements #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d code clarity and consistency
…Lint configuration
…roved structure and readability
…r better visual clarity
…les, and query runner dashboard
closes #41 |
gvieira18
requested changes
Nov 15, 2024
### Summary This pull request includes significant updates to the Docker and CI configurations. The changes aim to streamline the Docker setup, improve environment variable handling, and update the `docker-compose` network configurations. > [!NOTE] > With this update, we're moving to using the Alpine image at the development stage. So we can remove the `Dockerfile.bookworm` later. ### Changes: - [x] Added a new `Dockerfile.alpine` with environment variables, dependency installations, and user setup for a Node.js development environment. - [x] Removed the old `Dockerfile` which included multiple stages for building and running the application. - [x] Simplified the network configuration in `docker-compose.ghcr.yml` and `docker-compose.yml` by removing specific IP address assignments. - [x] Added `NEXT_TELEMETRY_DISABLED` and `COREPACK_ENABLE_DOWNLOAD_PROMPT` environment variables in the CI workflow configuration. --------- Signed-off-by: Gabriel do Carmo Vieira <[email protected]>
…od-dependencies group (basementdevs#85) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…pendencies group (basementdevs#86) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
gvieira18
approved these changes
Nov 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes multiple changes aimed at improving the user interface and functionality of various components in the application. The most important changes include modifications to the
KeyspaceInfo
andDashboardPage
components, as well as updates to the ESLint configuration and Dockerfile.Component Enhancements:
src/app/(main)/keyspace/[keyspace]/_components/keyspace-info.tsx
: Refactored theKeyspaceInfo
component to use the newKeyspaceInfoItem
component for better code reuse and readability. Updated theDeleteKeyspaceButton
to be disabled and display a "Work In Progress" tooltip. (src/app/(main)/keyspace/[keyspace]/_components/keyspace-info.tsxL61-R64, src/app/(main)/keyspace/[keyspace]/_components/keyspace-info.tsxL82-R79, src/app/(main)/keyspace/[keyspace]/_components/keyspace-info.tsxL102-R125, src/app/(main)/keyspace/[keyspace]/_components/keyspace-info.tsxL157-R170)src/app/(main)/keyspace/[keyspace]/_components/keyspace-tables.tsx
: Replaced the existing tooltip implementation with theCustomTooltip
component and adjusted table styles for consistency. (src/app/(main)/keyspace/[keyspace]/_components/keyspace-tables.tsxR1, src/app/(main)/keyspace/[keyspace]/_components/keyspace-tables.tsxL17-R18, src/app/(main)/keyspace/[keyspace]/_components/keyspace-tables.tsxL57-R87, src/app/(main)/keyspace/[keyspace]/_components/keyspace-tables.tsxL110-R140)src/app/(main)/page.tsx
: Enhanced theDashboardPage
component with improved layout and styling for the dashboard header, key features, and contributors sections.Configuration Updates:
.eslintrc.json
: Added new ESLint rules to disable specific unicorn plugin rules for code consistency.Dockerfile Update:
.docker/Dockerfile.bookworm
: Enabled corepack to ensure the correct version of package managers is used during the build process.UI