Fix dual for _TRUE and _FALSE #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pauleve Thank you ++ for this! let me review and merge shortly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
dualmember of operators is assumed to be a class. However, forTRUEandFALSE, it is an object.This leads to errors with
simplify()orliteralize()within thedemorgan()method when applied onTRUEorFALSEobjects (e.g., #85)There are two ways of fixing this: either assign the dual member of
TRUEandFALSEto the corresponding class, or add a__call__method to these objects returning themselves.This PR adopts the latter approach to respect as much as possible the singleton design pattern.